Skip to content

fix(push-noti): 푸시알림 전송 로직 오류 수정 (3) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pinkippo merged 1 commit into from
Sep 15, 2025
Merged

fix(push-noti): 푸시알림 전송 로직 오류 수정 (3) #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ...va/com/onebyone/kindergarten/domain/pushNotification/service/PushNotificationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ public void savePushNotification(PushNotificationRequestDTO requestDTO) {
/// FCM 통해 여러 알림 동시 전송 (비동기 처리)
@Transactional
public void sendAllFCMNotificationsByAsync(List<PushNotification> notifications) {
// 성공한 알림들을 저장할 리스트 (catch 블록에서도 접근 가능하도록 외부에 선언)
List<PushNotification> updatedNotifications = new ArrayList<>();

try {
// 알림이 비어있거나 null인 경우 처리
if (notifications == null || notifications.isEmpty()) {
Expand Down Expand Up @@ -194,7 +197,6 @@ public void onFailure(Throwable throwable) {
// 응답 결과 수집
int successCount = 0;
int failureCount = 0;
List<PushNotification> updatedNotifications = new ArrayList<>();

// 각 Future의 결과 처리
for (int i = 0; i < futures.size(); i++) {
Expand Down Expand Up @@ -235,7 +237,15 @@ public void onFailure(Throwable throwable) {

log.info("FCM 알림 배치 전송 요청 완료: {} 개", validNotifications.size());
} catch (Exception e) {
log.error("FCM 알림 전송 중 오류 발생하였지만 Job은 계속 실행됩니다: {}", e.getMessage());
// 예외가 발생하더라도 성공한 알림들은 반드시 상태 업데이트
if (!updatedNotifications.isEmpty()) {
try {
updateNotificationStatus(updatedNotifications);
log.info("성공한 알림 상태 업데이트 완료: {} 개", updatedNotifications.size());
} catch (Exception updateException) {
log.error("알림 상태 업데이트 중 추가 오류 발생: {}", updateException.getMessage(), updateException);
}
}
}
}

Expand Down