Add components to teams and kits #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theEvilReaper
added a commit
that referenced
this pull request
Aug 12, 2025
* Update renovate configuration to use our new schemas * Update release page url * Improve readme content * Update version in the readme file * Allow renovate to update the current version in the readme file * Fix wrong compare call * Remove the ability to change the name after a phase is created * Remove tests which deals with the name change * Fix missing parameter in super call * Update constructor definition * Update constructor usage in several test cases * Remove unused constructors * Overhaul team event structure * Update event calls * Update team event tests * Remove an empty line * Remove test class for the MultiPlayerTeamEvent * Add documentation * Update settings.gradle.kts * Add close invalid prs workflow * Add build pr workflow * Remove generic usage in the team service * Improve documentation * Update generic usage in the test * Remove generic usage in the team distribution * Add annotation to a parameter * Update dependency gradle to v9 (#25) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update gradle action usage * Overhaul documentation and add javaDoc task (#26) * Add java doc tasks * Add or improve documentation * Overhaul phase documentation * Small documentation adjustments * Add constructor documentation Add constructor documentation * Remove generic comment * Add missing documentation * Documentation changes * Improve parameter documentation * Improve constructor documentation * Fix typo in documentation --------- Co-authored-by: theEvilReaper <[email protected]> * Remove component check in the remove method * Improve jetbrains annotation usage * Update bom and aves dependency * Update actions/checkout action to v5 (#28) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add components to teams and kits (#27) * Add component structure * Add ColorComponent implementation * Add usage of the adventure key class * Remove unused team code * Update team relevant tests * Add DefaultTeam class * Remove team creator * More test updates for the team part * Add key usage to the kit part * Cleanup kit related code * Improve documentation * Rename some classes * Add TeamService integration test * Update constructor usage * Remove DefaultKitServiceTest * Remove debugs * Update compareTo * Overhaul team tests * Remove the ability to store which kit a player currently has * Remove the method which allows the removal of a kit via its object reference * Overhaul test structure from the kit service * Remove inheritance from the ItemShiftOption class * Add dedicated class for the test kit * Add KitTest class * Remove Aves integration --------- Co-authored-by: theEvilReaper <[email protected]> * Update version --------- Co-authored-by: theEvilReaper <[email protected]> Co-authored-by: Phillipp Glanz <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The pull request overhauls the kit and team structure by integrating
Components. These are classes that provide additional context to a team. This reduces structural complexity, as certain aspects can now be added through this new approach instead of creating new subclasses of a kit or team. These changes are breaking.Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.