-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add item model list pagination #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
51c9ec6
Switch list type to paginated result for the ItemModel
theEvilReaper aa0c508
Update item actions to support paginated results
theEvilReaper 8eb11b0
Update items call
theEvilReaper 365cc87
Update action names
theEvilReaper a3d014c
Replace remove with removeWhere call
theEvilReaper a616b1d
Update generated app state file
theEvilReaper 5d9d228
Improve count update when adding a new item
theEvilReaper f75233c
Add new variables to store for pagination requests
theEvilReaper 9e7e6f5
Add check to load more items
theEvilReaper 2c747eb
Add usage of the PaginatedBaseModelViewTabs widget
theEvilReaper 703810c
Fix wrong value access
theEvilReaper c3037e1
Improve documentation
theEvilReaper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The helper function doesn't update
totalPages
whentotalItems
changes, which could lead to inconsistent pagination state. Consider recalculatingtotalPages
whentotalItems
is provided:totalPages: totalItems != null ? (totalItems / state.items.pageSize).ceil() : state.items.totalPages
Copilot uses AI. Check for mistakes.