fix(proxy): support errors

OneOfOne · Jun 5, 2024 · 3085c90 · 3085c90
1 parent 4748c9e
commit 3085c90
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/proxy.go b/proxy.go
@@ -18,7 +18,7 @@ var hopHeaders = []string{
 	"Upgrade",
 }
 
-func ProxyHandler(host string, pathFn func(ctx *Context, path string) string) Handler {
+func ProxyHandler(host string, pathFn func(ctx *Context, path string) (string, error)) Handler {
 	rp := &httputil.ReverseProxy{}
 
 	scheme := "http"
@@ -52,8 +52,11 @@ func ProxyHandler(host string, pathFn func(ctx *Context, path string) string) Ha
 
 	return func(ctx *Context) Response {
 		if pathFn != nil {
-			ctx.Path()
-			ctx.Req.URL.Path = pathFn(ctx, ctx.Req.URL.Path)
+			p, err := pathFn(ctx, ctx.Req.URL.Path)
+			if err != nil {
+				return NewJSONErrorResponse(http.StatusBadRequest, err)
+			}
+			ctx.Req.URL.Path = p
 		}
 
 		rp.ServeHTTP(ctx, ctx.Req)

diff --git a/proxy_test.go b/proxy_test.go
@@ -19,8 +19,8 @@ func TestProxy(t *testing.T) {
 	s2 := newServerAndWait(t, "localhost:0")
 	defer s2.Shutdown(0)
 
-	s2.GET("/*fn", ProxyHandler(s.Addrs()[0], func(_ *Context, s string) string {
-		return "/api/" + s
+	s2.GET("/*fn", ProxyHandler(s.Addrs()[0], func(_ *Context, s string) (string, error) {
+		return "/api/" + s, nil
 	}))
 
 	http.Get("http://" + s2.Addrs()[0] + "/x")