Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add squared relu #10316

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Add squared relu #10316

merged 11 commits into from
Aug 22, 2023

Conversation

xiezipeng-ML
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Speed stats:

@github-actions
Copy link
Contributor

Speed stats:

@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 18, 2023 12:29
@github-actions
Copy link
Contributor

CI failed when running job: cpu-misc. PR label automerge has been removed

@github-actions
Copy link
Contributor

Speed stats:

@github-actions
Copy link
Contributor

Static analysis with clang failed. PR label automerge has been removed

@github-actions
Copy link
Contributor

Speed stats:

@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2023 04:37
@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/10316/

@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2023 07:30
@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2023 07:38
@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2023 12:52
@xiezipeng-ML xiezipeng-ML enabled auto-merge (squash) August 21, 2023 12:52
@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@github-actions
Copy link
Contributor

Speed stats:

@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2023 13:47
@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/10316/

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: NVIDIA GeForce RTX 3080 Ti 

❌ OneFlow resnet50 time: 43.7ms (= 4374.6ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 57.2ms (= 5722.2ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.31 (= 57.2ms / 43.7ms)

OneFlow resnet50 time: 26.2ms (= 2619.5ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 37.5ms (= 3754.9ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.43 (= 37.5ms / 26.2ms)

OneFlow resnet50 time: 19.6ms (= 3910.8ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 35.7ms (= 7132.4ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.82 (= 35.7ms / 19.6ms)

OneFlow resnet50 time: 19.8ms (= 3969.9ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 31.1ms (= 6224.5ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.57 (= 31.1ms / 19.8ms)

OneFlow resnet50 time: 18.7ms (= 3746.2ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 29.1ms (= 5825.0ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.55 (= 29.1ms / 18.7ms)

OneFlow swin dataloader time: 0.202s (= 40.466s / 200, num_workers=1)
PyTorch swin dataloader time: 0.127s (= 25.399s / 200, num_workers=1)
Relative speed: 0.628 (= 0.127s / 0.202s)

OneFlow swin dataloader time: 0.054s (= 10.704s / 200, num_workers=4)
PyTorch swin dataloader time: 0.033s (= 6.555s / 200, num_workers=4)
Relative speed: 0.612 (= 0.033s / 0.054s)

OneFlow swin dataloader time: 0.029s (= 5.885s / 200, num_workers=8)
PyTorch swin dataloader time: 0.017s (= 3.384s / 200, num_workers=8)
Relative speed: 0.575 (= 0.017s / 0.029s)

❌ OneFlow resnet50 time: 47.3ms (= 4730.9ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 63.2ms (= 6320.1ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.34 (= 63.2ms / 47.3ms)

OneFlow resnet50 time: 31.9ms (= 3187.4ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 45.8ms (= 4581.5ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.44 (= 45.8ms / 31.9ms)

OneFlow resnet50 time: 24.4ms (= 4879.9ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 42.4ms (= 8488.9ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.74 (= 42.4ms / 24.4ms)

OneFlow resnet50 time: 22.5ms (= 4507.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 36.8ms (= 7367.4ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.63 (= 36.8ms / 22.5ms)

OneFlow resnet50 time: 21.0ms (= 4209.6ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 34.7ms (= 6938.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.65 (= 34.7ms / 21.0ms)

@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2023 14:55
@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/10316/

@github-actions
Copy link
Contributor

Speed stats:

@xiezipeng-ML xiezipeng-ML requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 22, 2023 01:52
@github-actions
Copy link
Contributor

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/10316/

@github-actions
Copy link
Contributor

Speed stats: 
GPU Name: NVIDIA GeForce RTX 3080 Ti 

❌ OneFlow resnet50 time: 43.4ms (= 4344.0ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 61.4ms (= 6139.8ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.41 (= 61.4ms / 43.4ms)

OneFlow resnet50 time: 26.0ms (= 2604.7ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 37.8ms (= 3778.3ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.45 (= 37.8ms / 26.0ms)

OneFlow resnet50 time: 18.5ms (= 3692.2ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 35.7ms (= 7145.2ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.94 (= 35.7ms / 18.5ms)

OneFlow resnet50 time: 18.3ms (= 3661.7ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 32.1ms (= 6412.6ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.75 (= 32.1ms / 18.3ms)

OneFlow resnet50 time: 17.9ms (= 3574.8ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 28.5ms (= 5691.9ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.59 (= 28.5ms / 17.9ms)

OneFlow swin dataloader time: 0.201s (= 40.223s / 200, num_workers=1)
PyTorch swin dataloader time: 0.129s (= 25.785s / 200, num_workers=1)
Relative speed: 0.641 (= 0.129s / 0.201s)

OneFlow swin dataloader time: 0.054s (= 10.736s / 200, num_workers=4)
PyTorch swin dataloader time: 0.033s (= 6.646s / 200, num_workers=4)
Relative speed: 0.619 (= 0.033s / 0.054s)

OneFlow swin dataloader time: 0.031s (= 6.189s / 200, num_workers=8)
PyTorch swin dataloader time: 0.017s (= 3.342s / 200, num_workers=8)
Relative speed: 0.540 (= 0.017s / 0.031s)

❌ OneFlow resnet50 time: 47.5ms (= 4747.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 65.3ms (= 6527.0ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.37 (= 65.3ms / 47.5ms)

OneFlow resnet50 time: 31.4ms (= 3142.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 47.7ms (= 4767.2ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.52 (= 47.7ms / 31.4ms)

OneFlow resnet50 time: 23.9ms (= 4781.4ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 41.2ms (= 8236.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.72 (= 41.2ms / 23.9ms)

OneFlow resnet50 time: 22.4ms (= 4475.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 39.3ms (= 7861.9ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.76 (= 39.3ms / 22.4ms)

OneFlow resnet50 time: 21.3ms (= 4263.7ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 35.4ms (= 7076.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.66 (= 35.4ms / 21.3ms)

@xiezipeng-ML xiezipeng-ML merged commit 6e1fa45 into master Aug 22, 2023
35 of 52 checks passed
@xiezipeng-ML xiezipeng-ML deleted the add_ReLUSquaredActivation branch August 22, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofhwei ofhwei ofhwei approved these changes

@marigoold marigoold marigoold approved these changes

@doombeaker doombeaker Awaiting requested review from doombeaker doombeaker is a code owner

@hjchen2 hjchen2 Awaiting requested review from hjchen2 hjchen2 is a code owner

@jackalcooper jackalcooper Awaiting requested review from jackalcooper jackalcooper is a code owner

@liujuncheng liujuncheng Awaiting requested review from liujuncheng liujuncheng is a code owner

@Ldpe2G Ldpe2G Awaiting requested review from Ldpe2G

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
api documentation op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiezipeng-ML @marigoold @ofhwei @oneflow-ci-bot