add quantization conv and matmul #10327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Houjiang Chen <[email protected]>
…fix_dynamo_mock_error
…c/oneflow into fix_dynamo_mock_error
…c/oneflow into fix_dynamo_mock_error
…c/oneflow into fix_dynamo_mock_error
…into dev_int8_conv
…into dev_int8_conv
jackalcooper
reviewed
Sep 6, 2023
jackalcooper
reviewed
Sep 6, 2023
| return failure(); | ||
| } | ||
| } else { | ||
| result.replaceAllUsesWith(created_results[num_transposed_result]); |
There was a problem hiding this comment.
如果不全部替换，可能会出现原op的其他输出仍然被消费的情况，最后导致同时有两个同名的op存在
There was a problem hiding this comment.
可能会出现原op的其他输出仍然被消费的情况
这个是正常的吧，如果这个输出的消费者本来就不在这个NHWC优化的子图
最后导致同时有两个同名的op存在
这个是不是在 AutoNhwcPattern 里面把产生的新 op 的 op_name 改一下更好
There was a problem hiding this comment.
那就每个pattern都要改一下，要不你来改一下吧
…into dev_int8_conv
…into dev_int8_conv
…into dev_int8_conv
…into dev_int8_conv
hjchen2
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.