Actually pass the parent pointer to periodic updates. #196

Y-Less · 2023-02-28T04:22:33Z

add_can_lib_update_callback, like many other callback methods, takes a parentPointer and stores said pointer in CanLibUpdateCallbackInfo. However, unlike basically every other example of callbacks that I could find this meta-data is not actually passed to the callback itself, in fact the only place it seems to be used is in remove_can_lib_update_callback to confirm that you're removing the correct instance.

This updates the signatures and calls to actually pass the parent pointer to the callbacks themselves.

ad3154 · 2023-02-28T05:02:16Z

Hey there! Welcome to the project, and thanks for your contribution!

I think this is good for consistency, especially if we ever refactor the network manager to be a multiple instance object like was described in #161, in which case we will need to make this change anyways.

One thing I will note is that many compilers will complain about passing a value that is not used. One way to avoid this is to just omit the variable name from the consumer function. For example, if you change void update_CAN_network(void *parentPointer) to void update_CAN_network(void *) in the example files, most compilers will be happy and not generate a warning at compile time.

If you don't mind going back through and changing that in the example files, that would be most appreciated, and I'd be happy to approve your PR and get it merged in!

Thanks,

Adrian

ad3154 · 2023-02-28T05:26:52Z

address_claim_tests.cpp Also appears to be failing - just need to update that file similar to how you updated the example files and it'll be happy again.