Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix objects that can have a NULL object id as attribute #40

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GwnDaan
Copy link
Member

@GwnDaan GwnDaan commented Dec 13, 2023

There are attributes for some of the objects that are allowed to be the NULL object id. This PR wil fix working with pools that have those id's set to NULL.

@GwnDaan GwnDaan added bug Something isn't working iso: virtual terminal Related to the ISO-11783:6 standard labels Dec 13, 2023
@GwnDaan GwnDaan self-assigned this Dec 13, 2023
@GwnDaan GwnDaan force-pushed the daan/fix-nullable-object-ids- branch from 1ce3402 to baf3720 Compare December 13, 2023 18:02
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 167 lines in your changes are missing coverage. Please review.

Comparison is base (da74b03) 11.52% compared to head (b40a528) 10.68%.

Files Patch % Lines
src/object_pool/object.rs 0.00% 102 Missing ⚠️
src/object_pool/reader.rs 0.00% 45 Missing ⚠️
src/object_pool/writer.rs 0.00% 10 Missing ⚠️
src/object_pool/object_pool.rs 0.00% 6 Missing ⚠️
src/object_pool/object_id.rs 0.00% 3 Missing ⚠️
src/object_pool/vt_version.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   11.52%   10.68%   -0.84%     
==========================================
  Files          17       17              
  Lines        2664     2723      +59     
==========================================
- Hits          307      291      -16     
- Misses       2357     2432      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iso: virtual terminal Related to the ISO-11783:6 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants