Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke signed URLs #341

Open
m-mohr opened this issue Oct 28, 2020 · 2 comments · May be fixed by #381
Open

Revoke signed URLs #341

m-mohr opened this issue Oct 28, 2020 · 2 comments · May be fixed by #381
Labels
minor requires a minor-version (x.1.0 for example)
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Oct 28, 2020

The batch job results are provided as "signed" URLs. If you share the URLs, you can't revoke access except you delete the results. But maybe you want to keep the results, but just revoke access to the URLs you may have shared with others. Thus it could be useful to have an API endpoint to revoke the old signed URLs and generate new "signed" URLs.

@m-mohr m-mohr added the minor requires a minor-version (x.1.0 for example) label Oct 28, 2020
@m-mohr m-mohr added this to the future milestone Nov 25, 2020
@m-mohr m-mohr modified the milestones: future, 1.1.0 Dec 21, 2020
@m-mohr m-mohr modified the milestones: 1.1.0, future Apr 8, 2021
m-mohr added a commit that referenced this issue Apr 15, 2021
@m-mohr m-mohr linked a pull request Apr 15, 2021 that will close this issue
@m-mohr m-mohr linked a pull request Apr 15, 2021 that will close this issue
@soxofaan
Copy link
Member

I searched around a bit to find info or example implementations on revoking signed URLs but the results were disappointing so far. It seems that the most common approach to improve security is "use short expiration time" (order of minutes). The big implementations like AWS and google cloud don't seem to support revoking of signed URLs at all, except for nuclear options along the lines of "remove the resource" or "revoke the permissions of the resource owner".

So I wonder if there are some pitfalls to this feature request so that no backend will implement it in practice.

@m-mohr
Copy link
Member Author

m-mohr commented Apr 16, 2021

Yes, we will likely need to get more experience with this functionality first. It would also be interesting what other functionality may be required for batch job results (and/or the PATCH endpoint) so that we can figure out how to combine it.
The aim was to get a proposal up for experiments, but I doubt we'll release this in 1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor requires a minor-version (x.1.0 for example)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants