initial PoC implementation of UDPJobFactory #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
commented
Oct 10, 2024
soxofaan
commented
Oct 11, 2024
soxofaan
added a commit
that referenced
this pull request
Oct 11, 2024
soxofaan
added a commit
that referenced
this pull request
Oct 11, 2024
soxofaan
added a commit
that referenced
this pull request
Oct 11, 2024
soxofaan
force-pushed
the
issue604-udp-based-job-manager
branch
from
31d0c76
to
ff8b553
Compare
seems like pandas is handy to build foot guns maybe related to #641
soxofaan
commented
Oct 11, 2024
| @@ -13,8 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - `MultiBackendJobManager`: Added `initialize_from_df(df)` (to `CsvJobDatabase` and `ParquetJobDatabase`) to initialize (and persist) the job database from a given DataFrame. | |||
| Also added `create_job_db()` factory to easily create a job database from a given dataframe and its type guessed from filename extension. | |||
| ([#635](https://github.com/Open-EO/openeo-python-client/issues/635)) | |||
|
|
|||
|
|
|||
| - `MultiBackendJobManager.run_jobs()` now returns a dictionary with counters/stats about various events during the job run ([#645](https://github.com/Open-EO/openeo-python-client/issues/645)) | |||
| Batch job factory based on a parameterized process definition | ||
| (e.g a user-defined process (UDP) or a remote process definition), | ||
| to be used together with :py:class:`MultiBackendJobManager`. | ||
| """ |
| *, | ||
| namespace: Union[str, None] = None, | ||
| parameter_defaults: Optional[dict] = None, | ||
| parameter_column_map: Optional[dict] = None, |
There was a problem hiding this comment.
TODO test for parameter_column_map feature?
| @@ -886,3 +937,124 @@ def create_job_db(path: Union[str, Path], df: pd.DataFrame, *, on_exists: str = | |||
| else: | |||
| raise NotImplementedError(f"Initialization of {type(job_db)} is not supported.") | |||
| return job_db | |||
|
|
|||
|
|
|||
| class UDPJobFactory: | |||
There was a problem hiding this comment.
TODO: find better class name?
| """ | ||
| Batch job factory based on a parameterized process definition | ||
| (e.g a user-defined process (UDP) or a remote process definition), | ||
| to be used together with :py:class:`MultiBackendJobManager`. |
There was a problem hiding this comment.
TODO: usage example here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #604
self-review PR