Fixes #2199 Move DistributionType updates for cloning to the proper c…

…lass (#2200)
Open-Systems-Pharmacology · Jan 24, 2024 · f299281 · f299281
1 parent 1729908
commit f299281
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/OSPSuite.Core/Domain/Builder/IndividualParameter.cs b/src/OSPSuite.Core/Domain/Builder/IndividualParameter.cs
@@ -14,9 +14,9 @@ public override void UpdatePropertiesFrom(IUpdatable source, ICloneManager clone
       {
          base.UpdatePropertiesFrom(source, cloneManager);
          var sourceIndividualParameter = source as IndividualParameter;
-         if (sourceIndividualParameter == null) return;
+         if (sourceIndividualParameter == null) 
+            return;
 
-         DistributionType = sourceIndividualParameter.DistributionType;
          Info = sourceIndividualParameter.Info?.Clone();
          Origin = sourceIndividualParameter.Origin?.Clone();
          IsDefault = sourceIndividualParameter.IsDefault;

diff --git a/src/OSPSuite.Core/Domain/Builder/PathAndValueEntity.cs b/src/OSPSuite.Core/Domain/Builder/PathAndValueEntity.cs
@@ -85,9 +85,11 @@ public double? Value
       public override void UpdatePropertiesFrom(IUpdatable source, ICloneManager cloneManager)
       {
          base.UpdatePropertiesFrom(source, cloneManager);
-         var sourcePathAndValueEntity = source as PathAndValueEntity;
-         if (sourcePathAndValueEntity == null) return;
 
+         if (!(source is PathAndValueEntity sourcePathAndValueEntity)) 
+            return;
+
+         DistributionType = sourcePathAndValueEntity.DistributionType;
          Value = sourcePathAndValueEntity.Value;
          ContainerPath = sourcePathAndValueEntity.ContainerPath.Clone<ObjectPath>();
          DisplayUnit = sourcePathAndValueEntity.DisplayUnit;