Open
Conversation
- Bundler is not a requirement of any gem. - rcov doesn't work on Ruby 1.9. - rdoc is not a dependency.
- The #headers method on Request was removed and is now accessed via #options. - Clearly it was super important that the `follow_location` option needed to have its underscore removed.
Also some spec tidy up.
No more 'platform-api-?' checked or automatically prefixed.
Seriously, it calls directly into the Ethon library and the request method is never set anywhere that's accessible.
- Request#method has gone, it may or may not be in options. - Request#body also appears to be in options.
There's a lot less data from the V3 API, just the amounts and notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the AMEE Ruby gem to work with the v3 only AMEE-connect service, available at live.amee.com, so AMEE Discover can use it again.
It does this by:
authenticate methodused to fetch a new key when making API requests, in favour of just using HTTP Basic AuthSorry, the tests are totally broken on this at present, so this shouldn't really be merged in yet.