Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 12.x Shift #255

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Laravel 12.x Shift #255

wants to merge 12 commits into from

Conversation

lukas-staab
Copy link
Member

This pull request includes the changes for upgrading to Laravel 12.x. Feel free to commit any additional changes to the shift-140867 branch.

Before merging, you need to:

  • Checkout the shift-140867 branch
  • Review all pull request comments for additional changes
  • Run composer update (if the scripts fail, try with --no-scripts)
  • Clear any config, route, or view cache
  • Thoroughly test your application (no tests?, no CI?)

If you get stuck, never hesitate to email support. If you need more help with your upgrade, check out the Human Shifts.

@lukas-staab
Copy link
Member Author

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 2bd865f6 and make the config file changes manually.

@lukas-staab
Copy link
Member Author

ℹ️ Shift detected customized options within your configuration files which may be set with an ENV variable. To help keep your configuration files streamlined, you may set the following variables. Be sure adjust any values per environment.

DB_DATABASE=forge
DB_USERNAME=forge

Note: some of these may simply be values which changed between Laravel versions. You may ignore any ENV variables you do not need to customize.

1 similar comment
@lukas-staab
Copy link
Member Author

ℹ️ Shift detected customized options within your configuration files which may be set with an ENV variable. To help keep your configuration files streamlined, you may set the following variables. Be sure adjust any values per environment.

DB_DATABASE=forge
DB_USERNAME=forge

Note: some of these may simply be values which changed between Laravel versions. You may ignore any ENV variables you do not need to customize.

@lukas-staab
Copy link
Member Author

⚠️ The MAIL_ENCRYPTION environment variables has been renamed to MAIL_SCHEME. Shift did not find this variable referenced in your committed files, but you should review any additional locations where your environment is configured and update to the new variable name.

@lukas-staab
Copy link
Member Author

ℹ️ In a minor release of Laravel 11, the local storage disk was updated to use the storage/app/private folder. This keeps files organized within a subfolder, similar to the public disk.

Shift added the storage/app/private folder. However, to avoid potentially breaking your app, Shift did not change your configuration. If you want, you may migrate your files and update your local disk path in your config/filesystems.php file. If you are not using the local storage disk, you may go ahead and update the path.

@lukas-staab
Copy link
Member Author

ℹ️ Shift updated your dependencies for Laravel 12. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 12. Watch dealing with dependencies for tips on handling any Composer issues.

The following dependencies were updated by a major version and may have their own changes. You may check their changelog for any additional upgrade steps.

The following dependencies were not updated by Shift and may be incompatible. If Composer lists one of these packages as a problem, you should check for a newer version.

@lukas-staab
Copy link
Member Author

⚠️ Laravel 10 has added a return type of array to the Event broadcastOn and Notification via methods. However, you may still return a single channel from these methods.

Shift added the array return type to these methods in the following classes. You should review them to ensure you are returning an array, or remove the return type.

  • app/Notifications/NewComment.php

@lukas-staab
Copy link
Member Author

ℹ️ Starting with Laravel 10, PHP type hints were added within classes included in a Laravel application. In an effort to modernize your code, Shift automated this change where Laravel strictly specifies a type. If you prefer not to type hint your code you may revert this commit by running: git revert 0c87a8ae

@lukas-staab
Copy link
Member Author

ℹ️ All of the underlying Symfony components used by Laravel have been upgraded to Symfony 7.2. Shift detected references to Symfony classes within your application. These are most likely type hints and can safely be ignored. If you are using Symfony classes directly or experience issues relating to Symfony, you should review the Symfony change log for any additional changes.

@lukas-staab
Copy link
Member Author

⚗️ This Shift is still being refined. Please report any issues or suggestions to [email protected]. Your feedback is what helps improve the experience for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants