fix(sdk): route backend arg + export run() + surface installed tags (issue #156 H1-H3)#159
Merged
Conversation
…issue #156 H1-H3) H1: SDK load/install/install_category/update/remove/verify now route the backend argument to a Manager for that backend instead of ignoring it. H2: Added modeldock.run() to the public SDK surface and __all__, matching the CLI run command and ModelManager.run(). H3: info() now surfaces installed tags for both catalog and installed-but-uncatalogued models (the latter via the B1 fallback); added a test confirming installed_tags are reported. Co-Authored-By: Claude <noreply@anthropic.com>
|
🎉 Congratulations @himanshu231204! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #156 items H1, H2, and H3 for the 0.1.1 release.
H1 —
backendargument was ignoredThe SDK
load/install/install_category/update/remove/verifyfunctions took abackendargument but never used it (deadif backend is not None:branch). Now each routes to aManager(backend=backend)when a backend is supplied, so the argument is honored.H2 —
run()missing from the SDKModelManager.run()and the CLIruncommand existed, butmodeldock.runwas absent from the public API and__all__. Addedrun()tosrc/modeldock/__init__.pyand exported it, matching the documented API surface.H3 —
info()installed-tagsinfo()now surfaces installed tags for both catalog models and installed-but-uncatalogued models (the latter via the B1 fallback from PR #158). Added a test confirminginstalled_tagsare reported for an installed model.Tests
tests/unit/test_sdk_api.py: SDKrun()works and is exported;Manager(backend=...)sets the active backend;info()surfaces installed tags.Verification
Unit 113 passed, integration (excl. slow pull) 3 passed, e2e 16 passed.
ruff,ruff format,mypy --strictclean. Verified live against Ollama:md.run('mistral:latest', prompt=...)streams tokens;md.load('mistral:latest', backend='ollama')routes correctly.