fix(runtime): make pull() idempotent for already-installed models (is…#162
Merged
Conversation
…sue #156) BaseRuntime.pull() now short-circuits when the model is already installed, returning a successful PullResult(already_present=True) without re-downloading. This keeps repeated install()/load() calls cheap and avoids redundant network fetches — core package-manager behavior. Added already_present field to PullResult. Updated tests: idempotent pull skips daemon pull(); non-installed still invokes it. Made test_info installed-field assertion environment-agnostic (was hardcoding installed=False, which broke when llama3:8b is actually present). Co-Authored-By: Claude <noreply@anthropic.com>
|
🎉 Congratulations @himanshu231204! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sue #156)
BaseRuntime.pull() now short-circuits when the model is already installed, returning a successful PullResult(already_present=True) without re-downloading. This keeps repeated install()/load() calls cheap and avoids redundant network fetches — core package-manager behavior.
Added already_present field to PullResult. Updated tests: idempotent pull skips daemon pull(); non-installed still invokes it. Made test_info installed-field assertion environment-agnostic (was hardcoding installed=False, which broke when llama3:8b is actually present).
Summary
Changes
Testing
Checklist
feature/,fix/,docs/,refactor/,test/,chore/)mainAGENT.mdcoding standards (type hints, Pydantic v2, no genericException, no business logic in CLI)domain/andports/stay pure (no I/O, no framework imports)ruff,mypy --strict,bandit,pytestpyproject.tomlandsrc/modeldock/__init__.pyversions match (if release-related)