fix: resolve dataset path config and undeclared provider dependencies - #20
Merged
Conversation
- Point dataset config at an existing file (data/sample_questions.json) with explicit format; previously referenced a non-existent path/directory.
- Harden dataset loader factory to give a clear error for directory paths instead of a misleading 'set format' message.
- Support the common {items: [...]} wrapper in the JSON dataset loader.
- Declare LLM provider SDKs (openai, anthropic, groq, google-genai, tiktoken) as a new 'providers' optional extra in pyproject.toml.
- Make provider SDK imports lazy so modules import without the optional dependency and raise a clear ProviderError at instantiation.
- Fix missing 'import httpx' in test_anthropic.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Notes
Only files related to this fix were committed; pre-existing unrelated modifications (e.g. README.md) and untracked artifacts (reports/, docs) were left out.