fix(reports): normalize output paths with wrong extensions

[syf2211]

Summary

Fix generate_to_file() in MarkdownReport, JSONReport, and ComparisonReport so paths with a non-matching extension (e.g. results.txt) are normalized via with_suffix() instead of creating nested directory paths like results.txt/report.md.

Motivation

Fixes #84. HTMLReport and TerminalReport already used the correct path.suffix / with_suffix() pattern; the other three report generators still relied on endswith(), which misclassified wrong-extension paths as directories.

Changes

• openagent_eval/reports/markdown.py: normalize .md output paths
• openagent_eval/reports/json_report.py: normalize .json output paths
• openagent_eval/reports/comparison.py: normalize .txt output paths and align call order with other generators
• Added regression tests in tests/unit/test_reports/test_markdown.py, test_json_report.py, and test_comparison.py

Tests

python3 -m pytest tests/unit/test_reports/test_markdown.py tests/unit/test_reports/test_json_report.py tests/unit/test_reports/test_comparison.py -v

Result: 44 passed

Notes

• Behavior for extensionless paths (treated as directories) is unchanged.
• Case-insensitive suffix matching (.MD → .md) matches the existing HTMLReport/TerminalReport behavior.

[himanshu231204]

/oc review pr in details

[opencode-agent]

Review summary — strongly positive, approve.

Bug analysis

The old code in all three generators used str(path).endswith(".ext"):

# Before (broken)
path = Path(output_path)
if not str(path).endswith(".md"):      # e.g. "results.txt" → False
    path = path / "report.md"          # → "results.txt/report.md" ☠️

When given results.txt, endswith(".md") is False, so the code incorrectly treated it as a directory and created results.txt/report.md instead of normalizing to results.md.

What the fix does

Replaces endswith() with path.suffix-based three-way logic, matching the existing pattern in HTMLReport and TerminalReport:

# After (fixed)
path = Path(output_path)
if path.suffix == "":                   # no ext → directory
    path = path / "report.md"
elif path.suffix.lower() != ".md":      # wrong ext → normalize
    path = path.with_suffix(".md")

Per-file changes

File	Extension	Default filename	Bonus fix
markdown.py	.md	report.md	—
json_report.py	.json	report.json	—
comparison.py	.txt	comparison.txt	Moved _prepare_output_file() after path resolution (was called too early on raw output_path, creating spurious directories)

Tests

Each test file adds a regression test: report.txt → report.md (or .json / .txt), verifying equality, existence, and content validity. All 44 tests pass.

Minor observations

1. Duplicated logic — The suffix / with_suffix() pattern is now copy-pasted across all 5 generators. Worth extracting into a ReportGenerator._resolve_output_path() helper as a follow-up.
2. No case-insensitive test — .MD → .md works via .lower() but isn't tested (same gap in existing HTML/Terminal tests).
3. Comparison gap — comparison.py is missing the "extensionless → adds .txt" test that markdown.py and json_report.py have. Pre-existing, not introduced here.

Overall: Correct, minimal, consistent with existing patterns, well-tested.

opencode session  |  github run

[github-actions]

🎉 Congratulations @syf2211!

Your pull request has been successfully merged into main. 🚀

Thank you for contributing to OpenAgentHQ and helping improve the project.

We truly appreciate your contribution and hope to see you back with more amazing PRs!

Happy Open Sourcing! ❤️