test(diagnosis): regression lock for non-ASCII terms in content gap analysis#221
Merged
himanshu231204 merged 2 commits intoJul 23, 2026
Merged
Conversation
Add regression tests for OpenAgentHQ#64: content gap analysis must extract accented Latin keywords (French "différence", German "Größe") and non-empty keyword sets for CJK questions, rather than dropping them as the old `[a-zA-Z]{4,}` regex did. The production fix (switching to `\w{4,}`) already landed on main via commit 78c92a4 ("Fix OpenAgentHQ#122"), but there was no test guarding it — these tests fail against `[a-zA-Z]{4,}` and pass against `\w{4,}`, so a regression back to ASCII-only extraction would be caught. Refs OpenAgentHQ#64 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
🎉 Congratulations @Nitjsefnie! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Heads-up: the production fix for this is already on main — commit
78c92a4("Fix #122") changed the exact[a-zA-Z]{4,}→\w{4,}regex #64 asks about, so #64 is effectively a duplicate of #122. What was still missing is a regression test, so this PR is test-only: 4 tests exercising the issue's accented/CJK examples, verified to fail against the old[a-zA-Z]pattern (checked live by temporarily reverting the regex) and pass against\w.If you'd rather just close #64 as a duplicate without the test lock, no hard feelings — say so and I'll close this.
Gates:
uv run pytest tests/unit— 938 passed, 4 skipped (+4 new).Generated by Claude Fable 5 (brief, review), Claude Opus 4.8 (implementation)