Revert splitting out of coverage step #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
revert-codecov-changes
branch
from
c0b6912
to
5aa697d
Compare
|
Should have at least kept the |
|
Sorry I just did a plain revert as I was in a rush to fix things, will see if I can add that back later. |
|
Might take longer than you expect... I got inexplicable token error over at astropy/astropy#16535 Maybe not worth it and should spend the energy to get rid of codecov altogether... See #189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #199 as it is causing CI to fail in e.g. glue and reproject and other projects. We should make sure we test any follow-up repeat PR more extensively to make sure there are no more issues.