fix: update outdated examples in openbb-apachebeam #7286
+30
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Thanks for the PR and spotting some typos.
This part is not correct, |
- examples/openbb-apachebeam/README.md: Fix test-run command to point to example tests directory, fix typos and grammar - examples/openbb-apachebeam/requirements.txt: Add core 'openbb' dependency required by example - examples/openbb-apachebeam/tests/test_obb_pipeline.py: Fix code formatting, fix 'Print nes' typo to 'Print news' Fixes OpenBB-finance#7181
murataslan1
force-pushed
the
fix/outdated-examples-7181
branch
from
6fae89c to
c2e301f
Compare
Contributor
Author
|
@deeleeramone Thanks for the feedback! I'll revert the requirements.txt change. Should I do that in a new commit? |
Contributor
Author
|
@deeleeramone Done! I've reverted the requirements.txt change as suggested. The new commit only includes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes outdated examples in the
openbb-apachebeamdirectory.Changes
openbbdependency required by exampleFixes #7181
Testing
The changes are documentation and dependency fixes that don't require runtime testing.