fix(cli): prevent internal type annotations from leaking into help descriptions #7302
+28
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR addresses an issue in the
ArgparseTranslatorwhere internal Python type hints (such asUnion[...],Optional[...], andAnnotated[...]) were leaking into the CLI help messages from function docstrings. These annotations clutter the help output and can be confusing for end-users.Key Changes
_build_descriptionto strictly extract the function summary while stripping out redundant metadata sections likeParameters,Returns, andExampleswhich are already handled by argparse or are purely technical.clean_type_annotationhelper with more resilient regex patterns to handle varied spacing and nested type structures.int | str) andUnionobjects are consistently translated to human-readable "or" syntax (e.g.,int or str).Testing
pytest cli/tests/test_argparse_translator.pypasses.--helpnow displays clean, concise descriptions without implementation details.Potential Risks
Review Guide
_build_descriptionmethod to ensure they handle edge-case docstring indentations appropriately.Best regards,
Rin