Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

remove darwin x86_64 libbel.bundle #75

Closed
wants to merge 1 commit into from

Conversation

nbargnesi
Copy link
Member

Doesn't make sense to include this. It's for a specific version of Ruby
(2.1) expected to be found in /usr/local/lib.

Doesn't make sense to include this. It's for a specific version of Ruby
(2.1) expected to be found in /usr/local/lib.
@abargnesi
Copy link
Member

Yeah, this bundle linked against the Ruby I built it on. We still need to have a binary for Mac OSX when running on JRuby. JRuby does not build C extensions.

Any other solutions besides removing this entirely?

@abargnesi
Copy link
Member

Worth noting that the build failed with JRuby on Mac OSX.

https://travis-ci.org/OpenBEL/bel.rb/jobs/86387510

@abargnesi
Copy link
Member

We could include a Mac OSX library for Ruby 2.0, Ruby 2.1, and Ruby 2.2 linked against /usr/lib. Would that be sufficient?

@nbargnesi
Copy link
Member Author

On two of my Ruby 2.2 installations (both Macs), library resolution tries to load this particular bundle and fails. Until JRuby is used in earnest, I'd say punt this. For non-JRuby installs, we can rely on the extension being built as needed. I'm continuing to work through problems on this last point as well.

Here's what can happen now:

[94347] Puma starting in cluster mode...
[94347] * Version 2.13.4 (ruby 2.2.3-p173), codename: A Midsummer Code's Dream
[94347] * Min threads: 0, max threads: 2
[94347] * Environment: development
[94347] * Process workers: 4
[94347] * Phased restart available
[94347] * Listening on tcp://0.0.0.0:9000
[94347] Use Ctrl-C to stop
/Users/nick/projects/bel.rb/lib/bel/libbel.rb:49:in `rescue in load_libBEL': The C extension library could not be loaded for your platform. (BEL::LibBEL::LibraryLoadError)
Host information:
RUBY_PLATFORM:                x86_64-darwin15,
RbConfig::CONFIG['host_os']:  darwin15,
RbConfig::CONFIG['host_cpu']: x86_64,
library:                      libbel
Original error:
Name:                         LoadError,
Message:                      Could not open library '/Users/nick/projects/bel.rb/lib/bel/libbel/ext/libbel.bundle': dlopen(/Users/nick/projects/bel.rb/lib/bel/libbel/ext/libbel.bundle, 5): Library not loaded: /usr/local/lib/libruby.2.1.0.dylib
  Referenced from: /Users/nick/projects/bel.rb/lib/bel/libbel/ext/libbel.bundle
  Reason: image not found
        from /Users/nick/projects/bel.rb/lib/bel/libbel.rb:45:in `load_libBEL'

@abargnesi
Copy link
Member

Let's leave the library in at the moment. I've opened up #76 to track support for the libbel C extension within JRuby / Mac OSX.

@nbargnesi
Copy link
Member Author

This accepted openbel-server PR makes the included binary bundle a lot less noticeable. Now the bundle that gets loaded by openbel-server isn't something from a cloned repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants