Username Validation Incorrect Warning

[daniel-n-kaye]

This issue tracker is ONLY used for reporting bugs!

Expected Behavior

When editing your profile user name, you get an error when there are spaces in the user name. The warning message should probably say 'username cannot contain spaces' or something.

Current Behavior

The actual error message says 'Must start and end with a letter or number' which I think is incorrect

Possible Solution

Show correct user name validation warning, maybe something like "User name cannot contain spaces" or "User name must contain only letters and numbers"

[vnugent]

@daniel-n-kaye thank you for suggesting this!

@all-contributors add @daniel-n-kaye for idea

[allcontributors]

@vnugent

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @daniel-n-kaye! 🎉

[daniel-n-kaye]

@vnugent I'd be willing to try to take this on as a first issue, if that's ok, as it seems like it would hopefully be a pretty isolated update.

[vnugent]

The error messages are listed here

open-tacos/src/components/users/account/ProfileEditForm.tsx

Line 18 in 6f08aa1

.test('special-rules', 'Must start and end with a letter or a number.', checkUsername),

Since profile update code requires authentication with Auth0, please send an email: viet at openbeta dot io and I'll reply with some additional API keys for the dev environment.

[shoaib-31]

@vnugent I think my pull request will do the work.

[hawkishpolicy]

Is this still active?

[clintonlunn]

This is still an active issue. @danekshea any updates on your changes?

[vnugent]

I'm working on moving some of user profile functionality to our own DB. Username update is the first piece so I can take on this issue. What do you all think the error message should be?

Username validation rules:

1. cannot contain spaces or special characters
2. must begin with a letter

See #830

[hawkishpolicy]

Based on my understanding of the regex, it appears that it requires a username to begin and end with a letter or number.

It cannot contain spaces but it can contain "." or "-" or "_"

Would these be considered special characters?

I was brainstorming on how best to write this error message so that users can understand it clearly.

What about:

1. Must begin and end with a letter or number.
2. Can contain "." or "-" or "_"
3. Cannot contain spaces.

It's verbose but it is specific.

@zichongkao had some ideas.

That might be a long error message....we could break the regex into components so that it would trip each test as the User tried their new nickname.

[vnugent]

Would these be considered special characters?

dot and underscore are allowed (but not as the first character)

[hawkishpolicy]

I'm okay with it.