Fix: issue 718, improve validation message for user profile name edit

[danekshea]

Quick fix for #718 with an added description of the regex. Didn't test the build due to not having auth available, might be overflow due to length of message but the responsive UI probably handles it find.

[vercel]

@danekshea is attempting to deploy a commit to the openbeta-dev Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
open-tacos	✅ Ready (Inspect)	Visit Preview	Mar 30, 2023 at 6:29PM (UTC)

[vnugent]

can you please smoke test the change using the preview build? https://open-tacos-aa73c08rd-openbeta-dev.vercel.app/

thanks!

[vnugent]

you're right - there's not enough room for the long error message.

[zichongkao]

I looked into this briefly to find a path forward.

I see several options:

1. Change the error message display to accommodate larger messages. We could move to a toast, or a tool-tip like modal that is displayed on top of the page content. It could perhaps auto-disappear after several seconds or once the error is fixed.
2. Break up checkUsername (

   open-tacos/src/js/utils.ts

   Line 163 in d9f2d1a

   export const checkUsername = (uid: string): boolean => {

   ) into its three constituent subrules:

• "First and last characters have to be alphanumeric",
• "User name can only consist of alphanumeric and special characters: '.', '-', '_'"
• "At most one special character is permitted"
  each with its own check and dedicated error message.

3. Try a shorter error message: 'Username must be alphanumeric, optionally separated by a ".", "-" or "_".'
4. Simplify the checkUsername constraints so that it is more easily explained. Eg. "All alphanumeric only", or "Alphanumeric and special characters (., /, -)" + "special characters not permitted in first and last" (ie remove the "at most one special char" rule)

I'd favor 3 and 4. I feel like the current logic is somewhat hard to explain and fairly arbitrary. Perhaps "Only alphanumeric characters and ".", "_", "-" are permitted" would do.

[zichongkao]

@vnugent @danekshea What do y'all think?

[vnugent]

I'd be in favor of 3 and/or 4. Like you said we can break down the validation into multiple tests, each showing their own shorter message.

[danekshea]

3 and 4 sound pretty logical @zichongkao !

[vnugent]

superseded by #838