Skip to content

Commit

Permalink
fix: build break (#366)
Browse files Browse the repository at this point in the history
* fix: build break
* don't push docker img on pr
  • Loading branch information
vnugent committed Dec 10, 2023
1 parent e43370c commit dbc5659
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ on:
jobs:
# deploy to staging by commiting to api-server-deployment repo
deploy-staging:
runs-on: ubuntu-latest
if: github.ref_name == 'develop'
runs-on: ubuntu-22.04
# if: github.ref_name == 'develop'
needs: docker
steps:
- name: 'Checkout Project'
uses: 'actions/checkout@v4'
with:
fetch-depth: 1
repository: 'api-server-deployment'
repository: 'openbeta/api-server-deployment'
token: ${{ secrets.GH_DEPLOYMENT_REPO_TOKEN }}
- uses: imranismail/setup-kustomize@v2
- run: |
Expand All @@ -40,15 +40,15 @@ jobs:
# deploy to prod by commiting to api-server-deployment repo
deploy-prod:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: startsWith(github.ref, 'refs/tags/v')
needs: docker
steps:
- name: 'Checkout Project'
uses: 'actions/checkout@v4'
with:
fetch-depth: 1
repository: 'api-server-deployment'
repository: 'openbeta/api-server-deployment'
token: ${{ secrets.GH_DEPLOYMENT_REPO_TOKEN }}
- uses: imranismail/setup-kustomize@v2
- run: |
Expand All @@ -66,7 +66,8 @@ jobs:
# build docker image and push to registry
docker:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: github.event_name != 'pull_request'
needs: test
steps:
- name: 'Checkout Project'
Expand Down Expand Up @@ -106,7 +107,7 @@ jobs:

# setup basic machine to run all kinds of tests: lint, unit, integration, types
test:
runs-on: 'ubuntu-latest'
runs-on: 'ubuntu-22.04'
steps:
- name: 'Checkout Project'
uses: 'actions/checkout@v3'
Expand Down

0 comments on commit dbc5659

Please sign in to comment.