Skip to content

Commit

Permalink
build: always build dockerfile but skip pushing if PR
Browse files Browse the repository at this point in the history
  • Loading branch information
enapupe committed Dec 10, 2023
1 parent 937f825 commit de3f81d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ jobs:
# build docker image and push to registry
docker:
runs-on: ubuntu-22.04
if: github.event_name != 'pull_request'
needs: test
steps:
- name: 'Checkout Project'
Expand All @@ -93,7 +92,6 @@ jobs:
tags: |
type=ref,event=branch
type=semver,pattern={{raw}}
type=ref,event=pr
type=sha,format=long
- name: Build docker image
Expand All @@ -102,7 +100,7 @@ jobs:
context: ./
file: ./Dockerfile
builder: ${{ steps.buildx.outputs.name }}
push: true
push: github.event_name != 'pull_request'
tags: ${{ steps.meta.outputs.tags }}

# setup basic machine to run all kinds of tests: lint, unit, integration, types
Expand Down

0 comments on commit de3f81d

Please sign in to comment.