-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move user profile data from Auth0 #305
Conversation
fix: add username test mutation
@zichongkao @musoke can you please have a look at this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me!
@@ -36,18 +40,34 @@ const onConnected = async (): Promise<void> => { | |||
const userUuid = muuid.from(folderUuidStr) | |||
const f = fs.readFileSync(file.fullpath(), 'utf-8') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully these files are comprehensive. There's a risk that users can sign up and create new Auth0 accounts while this script is being run right? I can the rate of users joining is low, and we can check after the fact that the counts match up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a risk that users can sign up and create new Auth0 accounts while this script is being run right?
For this reason I disabled new user sign up before I downloaded all user folders/image files from Sirv a couple weeks ago. There's also a new check in the frontend for all logged in users. If a logged in user is not found in the Users collection, they must select a username which will then create a new document in Users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this all looks good to me!
chore: revert unrelated change in area resolver
#202 part 2
Overview
Note: Email is considered 'private'. Currently, email is not returned from any GQL queries.
Migration steps (staging and prod)
yarn import-users
to copy user public profile data from Auth0New queries & mutations
Useful for getting username from uuid
getUserPublicProfileByUuid()
currently not being used by the frontend (yet)Query for openbeta.io/u/<username> page
Does username exist?
Uses by the username change form to see if a username already exists