chore: new seed-db command #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musoke
approved these changes
Jun 9, 2023
siman4457
reviewed
Jun 19, 2023
| REMOTE_FILE="https://storage.googleapis.com/openbeta-dev-dbs/$FILE_NAME" | ||
|
|
||
| echo "Downloading db file(s)..." | ||
| #wget --content-disposition $REMOTE_FILE |
There was a problem hiding this comment.
@vnugent did you mean to comment this line out? yarn seed-db was failing since openbeta-stg-db.tar.gz wasn't actually getting downloaded.
There was a problem hiding this comment.
Ooops, good catch. Please uncomment it. Better yet, if you can improve the script so that we can either: download and rebuild db, or rebuild only (skip the download because it's a large file)
There was a problem hiding this comment.
Uncommented for now.
For improving the script:
Should the decision to download or skip download be from user input?
We can automatically start a download if we detect the tar file is outdated. Can we perform any versioning or date comparison between what's on Google storage and what we have locally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #309
I haven't figured out an automated way to redact emails so for the time being I manually exported the staging db, redacted emails manually and upload the new db file to google storage.