Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[delete] duplicate PR #351

Closed
wants to merge 38 commits into from
Closed

Conversation

l4u532
Copy link
Contributor

@l4u532 l4u532 commented Aug 24, 2023

Problem

(See #266)

For a given multi-pitch climb, for each pitch, we want to represent multiple boltsCount and grades, e. g. grade = ["6a", "6c", "5c", "6c"], and boltsCount = [4, 6, 3, 3], and possible other data (like description).

Solution

Introduce type Pitch (with fields parentIdtypenumbergradelengthboltsCountdescription) as a child to climb, so that climb gets an optional Array Climb.pitches containing each pitch; this has the most flexibility and allows for detailed per-pitch data, plus it wouldn't break any existing implementation

Example JSON Doc Schema

type Climb {
  id: ID!
  uuid: ID!
  name: String!
  ...
  pitches: [Pitch]!  # new pitches array of type Pitch
}

The Type Pitch would contain:

type Pitch {
  uuid: ID!
  parentId: ID!
  number: Int!
  grades: GradeType!
  type: ClimbType!
  length: Int!
  boltsCount: Int
  description: String
}

kl4us and others added 30 commits June 19, 2023 22:59
Update to sandbag 0.0.48 to get

- fixed slash grades (OpenBeta/sandbag#143)
- fixed VB grades (OpenBeta/sandbag#147)
- fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
@l4u532 l4u532 marked this pull request as draft August 24, 2023 13:25
@l4u532 l4u532 changed the title Add multipitch support [delete] duplicate PR Aug 24, 2023
@l4u532 l4u532 closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants