-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[delete] duplicate PR #351
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l4u532's UIAA changes
Update to sandbag 0.0.48 to get - fixed slash grades (OpenBeta/sandbag#143) - fixed VB grades (OpenBeta/sandbag#147) - fixed YDS grades > 5.9 with no letter (OpenBeta/sandbag#138)
…enbeta-graphql into add-multipitch-support
15c059d
to
74cd3d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
(See #266)
For a given multi-pitch climb, for each pitch, we want to represent multiple boltsCount and grades, e. g. grade = ["6a", "6c", "5c", "6c"], and boltsCount = [4, 6, 3, 3], and possible other data (like description).
Solution
Introduce type
Pitch
(with fieldsparentId
,type
,number
,grade
,length
,boltsCount
,description
) as a child toclimb
, so thatclimb
gets an optional ArrayClimb.pitches
containing each pitch; this has the most flexibility and allows for detailed per-pitch data, plus it wouldn't break any existing implementationExample JSON Doc Schema
The Type
Pitch
would contain: