Preserve complete URLs and support multiple link previews - #237
Draft
Xare123 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Messages containing multiple links could share one preview surface, and valid URL characters such as
+, query strings, fragments, percent escapes, and parentheses could fall outside the clickable range.Change
Parse complete URL ranges, keep same-host links with different paths separate, and cache/render metadata per URL. Bare image URLs retain preview fallback behavior.
Validation
Focused Flutter tests pass: 5/5, covering multiple paths,
+, percent escapes, queries, fragments, parentheses, sentence punctuation, and modern TLDs.Non-goals
This does not change draft retention, send queue behavior, attachments, FaceTime, or CloudKit.