cmd and cmd_raw raise on bad item states #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
==========================================
- Coverage 76.40% 76.38% -0.03%
==========================================
Files 618 618
Lines 46858 46901 +43
Branches 845 849 +4
==========================================
+ Hits 35803 35826 +23
- Misses 10959 10976 +17
- Partials 96 99 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
Oct 24, 2024
| range_check_value = item.states[value.to_s.upcase] | ||
| else | ||
| if command.raw | ||
| unless item.states.values.include?(value) |
There was a problem hiding this comment.
We should allow raw or converted states unless raw. If raw then only should accept raw states.
|
ryanmelt
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1471
Wait until COSMOS 6 to merge this behavior change.