Skip to content

Conversation

@delemaf
Copy link
Member

@delemaf delemaf commented Sep 26, 2025

Proposed changes

  • We want to disable the validation_mode selection when app:validation_mode is specified in config file

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@delemaf delemaf self-assigned this Sep 26, 2025
@delemaf delemaf added the filigran team use to identify PR from the Filigran team label Sep 26, 2025
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.13%. Comparing base (fe38883) to head (0bcafeb).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12565      +/-   ##
==========================================
- Coverage   65.73%   65.13%   -0.61%     
==========================================
  Files         745      752       +7     
  Lines       75314    76708    +1394     
  Branches     8530     8608      +78     
==========================================
+ Hits        49506    49960     +454     
- Misses      25808    26748     +940     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

"Validate this workbench": "Validate this workbench",
"Validated": "Validated",
"Validation mode": "Validation mode",
"Validation mode has already been setted in platform configuration": "Validation mode has already been setted in platform configuration",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo, it's set and not setted

@JeremyCloarec
Copy link
Contributor

I think there is a misunderstanding from the initial reported issue. The app:validation_mode is only relevant for the import csv connector, and not relevant for the other import file connectors: we would need to know the CONNECTOR_VALIDATE_BEFORE_IMPORT configuration of the connector.
We'll need to sync on this to know how we want to tackle the issue

@delemaf delemaf marked this pull request as draft October 22, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The validation mode chosen during file import is not taken into account

3 participants