Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration test #148

Merged
merged 11 commits into from
Jan 12, 2024
Merged

fix: integration test #148

merged 11 commits into from
Jan 12, 2024

Conversation

zixiang2018
Copy link
Contributor

@zixiang2018 zixiang2018 commented Jan 9, 2024

What this PR does

  1. fix npm run integration:local
  2. fix npm run e2e:local
  3. use .env variables in email sls
  4. update .env.example's bucket name to match storage's serverless default BUCKET_NAME
  5. standardize .js files with handler to use ESM exporting - export const handler = middy()...
  6. standardize all .js files handler to remove callback; use async/await (recommended by https://docs.aws.amazon.com/lambda/latest/dg/nodejs-handler.html)
  7. turn off import/prefer-default-export in eslintrc for (5) to work
  8. turn off prefer-regex-literals for test/utils/matcher.js

Pipeline

Copy link

seed-deploy bot commented Jan 9, 2024

View stack outputs

@zixiang2018 zixiang2018 merged commit f951b97 into master Jan 12, 2024
6 of 10 checks passed
@zixiang2018 zixiang2018 deleted the fix/integration-test branch January 12, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants