Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(example): auto generate example when missing in deep prop #59

Merged
merged 4 commits into from
Feb 19, 2024
Merged

feat(example): auto generate example when missing in deep prop #59

merged 4 commits into from
Feb 19, 2024

Conversation

sidux
Copy link
Collaborator

@sidux sidux commented Feb 16, 2024 •
edited
Loading

This also causes the a bug where a response (and it's status) are completely ignored when it doesn't now have an example for required properties)

  • need to comment all instances of "uniqueItems: true" in doc till we fix the faker lib

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 16, 2024 •
edited
Loading

Issued by Coverage Checker:

Coverage

✅ Your code coverage has not been degraded 🎉

Measure Main branch refs/pull/59/merge
Coverage 43.894% 43.952%
Total lines 3005 3001
Covered lines 1319 1319

∆ 0.058

@sidux sidux requested a review from Wilkins February 19, 2024 09:45
@sidux sidux merged commit 3f2f62e into main Feb 19, 2024
4 checks passed
@sidux sidux deleted the OC-50512_fix_response_ignored_on_missing_example branch February 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DotnDev DotnDev DotnDev approved these changes

@oliviersorine oliviersorine Awaiting requested review from oliviersorine

@Wilkins Wilkins Awaiting requested review from Wilkins

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidux @DotnDev