chore(examples): Added DeepObject parameter handling to generate appropriate examples #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issued by Coverage Checker: Coverage ❌ Your code coverage has been degraded 😭
∆ -0.150 🟢
🔴
|
DotnDev
commented
Aug 6, 2024
| @@ -22,7 +22,7 @@ public function getStatusCode(): ?string | |||
| return $this->statusCode; | |||
| } | |||
|
|
|||
| public function setStatusCode(string|TaggedValue|null $statusCode): void | |||
| public function setStatusCode(string|TaggedValue|int|null $statusCode): void | |||
There was a problem hiding this comment.
when the config only mentions a return code, it's treated as an int, not a TaggedValue
DotnDev
commented
Aug 6, 2024
src/Util/Path.php
Outdated
Comment on lines
18
to
30
| public static function getFullPath(string $path): string | ||
| { | ||
| $dir = \dirname(__DIR__); | ||
|
|
||
| while (!in_array('vendor', \scandir($dir), true)) { | ||
| if ($dir === \dirname($dir)) { | ||
| return $dir . '/' . trim($path, '/'); | ||
| } | ||
| $dir = \dirname($dir); | ||
| } | ||
|
|
||
| return $dir . '/' . trim($path, '/'); | ||
| } |
There was a problem hiding this comment.
the Yaml::parseFile() was breaking as the path needs to be absolute
DotnDev
commented
Aug 6, 2024
| @@ -46,7 +46,7 @@ suites: | |||
| names: [ 'RangeConfig' ] | |||
| unit: items | |||
| - name: examples | |||
| extensionPath: tests/Fixtures/Examples/oc | |||
| extensionPath: 'tests/Fixtures/Examples/petstore/examples.new.yml' | |||
There was a problem hiding this comment.
Using an existing file so the PlanTest.testOC() can work (the code related to the extension expects an 'operation' key and this file has one)
DotnDev
force-pushed
the
chore_examples_add_param_deep_object_handling
branch
from
b23d66a to
62772da
Compare
sidux
reviewed
Aug 8, 2024
sidux
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new filters format (using deepObject) needs to be supported by APITester to generate appropriate examples.