Avoid nested scrolling in the code session rail - #4488
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Code surface sessions rail so that, in the wide layout, scrolling is owned by the shared SurfaceRail container (avoiding nested scroll areas), while the narrow “list-first” drill-in layout keeps its own independent scrolling. It also extends the existing surface contract test to pin this behavior.
Changes:
- In
CodeSessionRail, conditionally removeoverflow-y-autowhen the rail is hosted insideSurfaceRail(detected via the presence ofonExpand). - Preserve
overflow-y-autofor the standalone narrow layout whereCodeSessionRailmust remain scrollable. - Add assertions to the code surface contract test to lock in the open-state scrolling class contract.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/components/code-session-rail.tsx | Introduces a layout-sensitive open-state class so wide SurfaceRail usage avoids nested scrolling while narrow standalone usage remains scrollable. |
| src/components/code-surface-mode.test.ts | Adds contract assertions to ensure the rail’s open-state scrolling behavior remains stable across both layout paths. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SurfaceRailown scrolling for the wide Code sessions railVerification
pnpm typecheckpnpm lintpnpm test:apppnpm test:apipnpm check:tests-wiredBead:
cave-iixug