Fix/goal background pause - #39
Open
BunsDev wants to merge 11 commits into
Open
Conversation
Define the upstream path-scoped goal boundary, bounded iOS lifecycle, privacy-safe ActivityKit surface, and release acceptance criteria. Record the completed Familiar bead and claim issue #13 for implementation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ven/coven-pocket into fix/goal-background-pause
There was a problem hiding this comment.
Pull request overview
This PR ensures active /goal runs are explicitly paused when the app transitions to the background, so an interrupted goal loop isn’t treated as still active on a later resume.
Changes:
- Add
ChatModel.pauseGoalForBackground()to persist an active goal pause during backgrounding. - Hook
scenePhasechanges inCovenPocketAppto trigger the background pause. - Update Beads issue tracker exports to reflect recent roadmap/issue status changes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/Sources/Support/ChatModel.swift | Adds a dedicated async entrypoint to pause an active goal when backgrounding. |
| app/Sources/CovenPocketApp.swift | Observes scenePhase and triggers goal pause on .background. |
| .beads/issues.jsonl | Updates issue records/notes; includes new/updated entries. |
| .beads/interactions.jsonl | Records additional issue field-change interactions. |
Suppressed comments (1)
.beads/issues.jsonl:57
- This issue note embeds an absolute local filesystem path (including the local username). Repo-tracked issue notes should avoid machine-specific paths; describe the worktree/branch without including the local path.
{"_type":"issue","id":"pocket-t3h","title":"Remote MCP servers (streamable HTTP/SSE + OAuth)","description":"Engine MCP client over streamable HTTP/SSE (no stdio on iOS); OAuth tokens in Keychain; server management UI; permission-mode aware. https://github.com/OpenCoven/coven-pocket/issues/14","notes":"2026-07-31: isolated worktree /Users/buns/.config/superpowers/worktrees/coven-pocket/remote-mcp-servers created at origin/main f6c83dc. Rust baseline: 275 passed, 1 network-only ignored. Recommended first slice is upstream host-adaptable remote MCP/OAuth plus Pocket server control plane; defer ChatSession tool injection until the on-device goal turn-boundary refactor lands.","status":"in_progress","priority":2,"issue_type":"feature","assignee":"Val Alexander","owner":"bunsthedev@gmail.com","created_at":"2026-07-22T00:06:42Z","created_by":"Val Alexander","updated_at":"2026-07-31T16:41:39Z","started_at":"2026-07-31T16:21:11Z","external_ref":"gh-14","labels":["m3"],"dependencies":[{"issue_id":"pocket-t3h","depends_on_id":"pocket-bpa","type":"blocks","created_at":"2026-07-21T19:07:16Z","created_by":"Val Alexander","metadata":"{}"}],"dependency_count":1,"dependent_count":0,"comment_count":0}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {"_type":"issue","id":"pocket-hoh.2","title":"Pocket on-device goal runtime","description":"Pin upstream, add checked goal storage, typed UniFFI lifecycle, autonomous continuation, and session cleanup integration.","status":"open","priority":2,"issue_type":"task","owner":"bunsthedev@gmail.com","created_at":"2026-07-31T16:16:43Z","created_by":"Val Alexander","updated_at":"2026-07-31T16:16:43Z","labels":["m3"],"dependencies":[{"issue_id":"pocket-hoh.2","depends_on_id":"pocket-hoh","type":"parent-child","created_at":"2026-07-31T11:16:43Z","created_by":"Val Alexander","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0} | ||
| {"_type":"issue","id":"pocket-hoh.1","title":"Upstream path-scoped goal APIs","description":"Add explicit-path continuation/completion, atomic progress, and active-goal reconciliation in coven-code; merge before Pocket pin bump.","status":"in_progress","priority":2,"issue_type":"task","assignee":"Val Alexander","owner":"bunsthedev@gmail.com","created_at":"2026-07-31T16:16:38Z","created_by":"Val Alexander","updated_at":"2026-07-31T16:17:18Z","started_at":"2026-07-31T16:17:18Z","labels":["m3"],"dependencies":[{"issue_id":"pocket-hoh.1","depends_on_id":"pocket-hoh","type":"parent-child","created_at":"2026-07-31T11:16:38Z","created_by":"Val Alexander","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0} | ||
| {"_type":"issue","id":"pocket-62j","title":"Consolidate merged and dirty worktrees","description":"Audit all Pocket and coven-code worktrees after the on-device goal release. Preserve unique validated changes, remove generated/stale clean worktrees, update local main branches to origin/main, and avoid disturbing the active remote-MCP branch.","notes":"Removed clean merged Pocket worktrees for PRs #33, #34, #37, and #38 and deleted their local branches; removed detached engine PR #175 worktree; pruned stale engine worktree metadata; fast-forwarded coven-code main to 529c103 and Pocket local main/remote-MCP baseline to e193aea. Active remote-MCP branch remains clean and preserved.","status":"in_progress","priority":2,"issue_type":"task","assignee":"Val Alexander","owner":"bunsthedev@gmail.com","created_at":"2026-08-01T09:02:29Z","created_by":"Val Alexander","updated_at":"2026-08-01T09:08:01Z","started_at":"2026-08-01T09:02:50Z","dependency_count":0,"dependent_count":0,"comment_count":0} | ||
| {"_type":"issue","id":"pocket-hoh.5","title":"Close on-device goal roadmap and issue","description":"The on-device goal implementation and background-lifecycle fix merged in Pocket PRs #36 and #37 with green CI, and pocket-hoh is closed, but ROADMAP.md still marks the M3 item incomplete and GitHub issue #13 remains open. Update the roadmap on an isolated branch, merge it, then close issue #13 with PR and engine evidence.","notes":"2026-08-01: isolated worktree /Users/buns/.config/superpowers/worktrees/coven-pocket/close-on-device-goals on docs/close-on-device-goals from origin/main. ROADMAP.md now marks on-device /goal complete with durable lifecycle, bounded background continuation, privacy-safe Live Activity progress, and Companion scope. Diff check passes. Awaiting commit/push authority before PR/merge and GitHub issue #13 closure.\n2026-08-01: committed roadmap closure as 7d5383c, opened PR #38, both Rust and iOS CI passed, merged as e193aea8a45975e143021126a52d8f5446fb36d9, and GitHub issue #13 auto-closed.","status":"closed","priority":2,"issue_type":"task","assignee":"Val Alexander","owner":"bunsthedev@gmail.com","created_at":"2026-08-01T08:37:23Z","created_by":"Val Alexander","updated_at":"2026-08-01T08:50:17Z","started_at":"2026-08-01T08:37:35Z","closed_at":"2026-08-01T08:50:17Z","close_reason":"Roadmap closure merged in PR #38 (e193aea8); issue #13 closed.","labels":["m3"],"dependencies":[{"issue_id":"pocket-hoh.5","depends_on_id":"pocket-hoh","type":"parent-child","created_at":"2026-08-01T03:37:22Z","created_by":"Val Alexander","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0} |
Adds UIInterfaceOrientationPortraitUpsideDown to the iPad supported orientations in project.yml to satisfy Xcode's requirement that all interface orientations be supported when the app does not require full screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.