fix(ios): clear the three SwiftLint violations failing CI - #40
Merged
Conversation
`iOS app build` has been red on main at the SwiftLint step. All three violations are whitespace, none of them affect behaviour: - RootView.swift ended with three newlines instead of one, tripping both trailing_newline and vertical_whitespace on line 302. - ChatView.swift had a double blank line before `canSend` (line 47). Verified with CI's exact command, `swiftlint lint --strict`: 0 violations in 97 files, down from "3 violations, 3 serious".
There was a problem hiding this comment.
🟢 Ready to approve
Changes are limited to whitespace-only edits that resolve SwiftLint violations with no functional impact.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR fixes SwiftLint CI failures on main by removing extra blank lines that triggered whitespace-related lint violations, without changing any runtime behavior.
Changes:
- Remove extra trailing blank lines at the end of
RootView.swift. - Remove an extra blank line in
ChatView.swiftbeforecanSend.
File summaries
| File | Description |
|---|---|
| app/Sources/Views/RootView.swift | Removes extra trailing blank lines to satisfy trailing_newline / vertical_whitespace rules. |
| app/Sources/Views/ChatView.swift | Removes a double-blank gap to satisfy vertical_whitespace rules. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS app buildhas been red onmainat the SwiftLint step, not at compile. All three violations are whitespace and none affect behaviour:RootView.swifttrailing_newline— file ended with three newlines instead of oneRootView.swiftvertical_whitespace— 2 blank linesChatView.swiftvertical_whitespace— double blank beforecanSendThe diff is 3 deleted blank lines and nothing else.
Verification
Ran CI's exact command locally (
swiftlint lint --strict, SwiftLint 0.63.2, the same versionbrew install swiftlintprovides):down from
Found 3 violations, 3 serious in 97 files.This only unblocks the SwiftLint step. The later steps in that job (
Build XCFramework,xcodegen generate, the simulator build) never ran while SwiftLint was failing, so this PR is the first time they get exercised on this code — if one of them is also broken, it will surface here rather than onmain.Once
iOS app buildis green, it can be added to the required checks alongsideRust (host + iOS targets).