Open files in focused fullscreen canvas - #74
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Tauri web UI’s “focus/fullscreen canvas” presentation so it also applies cleanly to fullscreen file editing, including a file-aware minimap entry and more robust escape/return behavior during lifecycle edge cases (pane hide/close, dirty-file guards).
Changes:
- Add a “file” entry to the pane minimap (with styling) so fullscreen files participate in the same focused canvas affordances as maximized panes.
- Route
Escapeto return from fullscreen file focus (and stopEscapepropagation from the dirty-file dialog so it doesn’t accidentally trigger file return). - Preserve file focus state when the underlying active pane is hidden/closed, and refresh minimap/workspace correctly when leaving/closing files.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| native/macos/psyche-build-tauri/web/styles.css | Adds styling for minimap “file” dots so the active file is visually distinct. |
| native/macos/psyche-build-tauri/web/main.js | Implements file-aware minimap entries, guarded return-from-file-focus via Escape, and file-focus retention across pane removal. |
| tests/tauriWorkspaceEditorIntegration.test.ts | Strengthens source extraction and adds coverage for Escape routing, minimap refresh, and file-focus lifecycle. |
| tests/tauriPhysicalPanes.test.ts | Adds coverage for minimap rendering with empty layouts and file-focus retention when underlying panes are removed. |
| tests/tauriCovenLaunch.test.ts | Updates harness injections for the new retainFileFocusAfterThreadRemoval dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
BunsDev
force-pushed
the
feature/fullscreen-file-view
branch
from
August 10, 2026 22:13
4b98cdb to
9b39625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
pnpm vitest --run __tests__/tauriWorkspaceEditorIntegration.test.ts __tests__/tauriPhysicalPanes.test.ts __tests__/tauriWorkspacePanels.test.ts __tests__/tauriDesktopTabs.test.ts __tests__/tauriCovenLaunch.test.tspnpm typecheckpnpm --filter psyche-build-tauri run build:webenv PATH="/usr/bin:/bin:/usr/sbin:/sbin:$PATH" pnpm test