Skip to content

Open files in focused fullscreen canvas - #74

Merged
BunsDev merged 6 commits into
mainfrom
feature/fullscreen-file-view
Aug 10, 2026
Merged

Open files in focused fullscreen canvas#74
BunsDev merged 6 commits into
mainfrom
feature/fullscreen-file-view

Conversation

@BunsDev

@BunsDev BunsDev commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • open files in the same focused canvas presentation as maximized panes
  • add a file-aware pane minimap with guarded pane switching and Escape return
  • preserve fullscreen files across pane hide/close lifecycle edge cases

Test Plan

  • pnpm vitest --run __tests__/tauriWorkspaceEditorIntegration.test.ts __tests__/tauriPhysicalPanes.test.ts __tests__/tauriWorkspacePanels.test.ts __tests__/tauriDesktopTabs.test.ts __tests__/tauriCovenLaunch.test.ts
  • pnpm typecheck
  • pnpm --filter psyche-build-tauri run build:web
  • env PATH="/usr/bin:/bin:/usr/sbin:/sbin:$PATH" pnpm test

Copilot AI lite review requested due to automatic review settings August 10, 2026 21:25
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
psyche-build-docs Ready Ready Preview Aug 10, 2026 10:13pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Tauri web UI’s “focus/fullscreen canvas” presentation so it also applies cleanly to fullscreen file editing, including a file-aware minimap entry and more robust escape/return behavior during lifecycle edge cases (pane hide/close, dirty-file guards).

Changes:

  • Add a “file” entry to the pane minimap (with styling) so fullscreen files participate in the same focused canvas affordances as maximized panes.
  • Route Escape to return from fullscreen file focus (and stop Escape propagation from the dirty-file dialog so it doesn’t accidentally trigger file return).
  • Preserve file focus state when the underlying active pane is hidden/closed, and refresh minimap/workspace correctly when leaving/closing files.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
native/macos/psyche-build-tauri/web/styles.css Adds styling for minimap “file” dots so the active file is visually distinct.
native/macos/psyche-build-tauri/web/main.js Implements file-aware minimap entries, guarded return-from-file-focus via Escape, and file-focus retention across pane removal.
tests/tauriWorkspaceEditorIntegration.test.ts Strengthens source extraction and adds coverage for Escape routing, minimap refresh, and file-focus lifecycle.
tests/tauriPhysicalPanes.test.ts Adds coverage for minimap rendering with empty layouts and file-focus retention when underlying panes are removed.
tests/tauriCovenLaunch.test.ts Updates harness injections for the new retainFileFocusAfterThreadRemoval dependency.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

BunsDev and others added 6 commits August 10, 2026 17:06
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@BunsDev
BunsDev force-pushed the feature/fullscreen-file-view branch from 4b98cdb to 9b39625 Compare August 10, 2026 22:13
@BunsDev
BunsDev merged commit f0b5298 into main Aug 10, 2026
3 checks passed
@BunsDev
BunsDev deleted the feature/fullscreen-file-view branch August 10, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants