Progress on #235, adding unaligned copy. #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry. Didn't have time to fix the gcc errors. Will do that tomorrow but I wanted to get the code to you sooner for review. |
thirtytwobits
force-pushed
the
uavcan-v1/issues/235-2
branch
from
f57b5c0 to
8553255
Compare
|
Okay. I think this is good. Honestly I won't know for sure till I start using it. The next step is to start building the presentation layer which will utilize this. |
Adding a version of unaligned copy for little-endian platforms that provides a single abstraction for vectorized unaligned copy. This replaces the v0 BitStream + unalignedCopy abstractions making a v1 "bit stream" into simply an std::vector and a std::size_t bit_offset. The abstraction allows the vector's word size to be parameterized which could provide better optimizations where a given architecture can perform single operations across multiple bytes instead of hard-coding all 8-bit operations. The usefulness versus complexity of this optimization will play out in subsequent pull-requests as we start utilizing this copy operation in the generated dsdl types. Progress on OpenCyphal-Garage#235, adding unaligned copy Version 2 of this utility. This one is endian agnostic (I think).
thirtytwobits
force-pushed
the
uavcan-v1/issues/235-2
branch
from
8553255 to
d360245
Compare
pavel-kirienko
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a version of unaligned copy for little-endian platforms that
provides a single abstraction for vectorized unaligned copy. This
replaces the v0 BitStream + unalignedCopy abstractions making a v1
"bit stream" into simply an std::vector and a std::size_t bit_offset.
The abstraction allows the vector's word size to be parameterized which
could provide better optimizations where a given architecture can
perform single operations across multiple bytes instead of hard-coding
all 8-bit operations. The usefulness versus complexity of this
optimization will play out in subsequent pull-requests as we start
utilizing this copy operation in the generated dsdl types.