Fixes blank line warnings and the easy obsolete warnings

Content.IntegrationTests/GameTests.cs

@@ -5,7 +5,6 @@
 namespace Content.IntegrationTests;
 [TestFixture]
 public sealed class GameTests : ContentIntegrationTest {
-
     /// <summary>
     /// Tests to make sure the IntegrationTest project does not runtime.
     /// </summary>

DMCompiler/Compiler/CompilerError.cs

@@ -23,6 +23,7 @@ public enum WarningCode {
     DanglingOverride = 405,
     StaticOverride = 406,
     FinalOverride = 407,
+
     // ReSharper disable once InconsistentNaming
     IAmATeaPot = 418, // TODO: Implement the HTCPC protocol for OD
     HardConstContext = 500,

DMCompiler/Compiler/DM/AST/DMAST.Expression.cs

@@ -201,6 +201,7 @@ public abstract class Operation {
         /// The location of the operation.
         /// </summary>
         public required Location Location;
+
         /// <summary>
         /// Whether we should short circuit if the expression we are accessing is null.
         /// </summary>
@@ -212,6 +213,7 @@ public abstract class NamedOperation : Operation {
         /// Name of the identifier.
         /// </summary>
         public required string Identifier;
+
         /// <summary>
         /// Whether we should check if the variable exists or not.
         /// </summary>
@@ -247,7 +249,6 @@ public sealed class DMASTCallableProcIdentifier(Location location, string identi
 }
 
 public sealed class DMASTCallableSuper(Location location) : DMASTExpression(location), IDMASTCallable;
-
 public sealed class DMASTCallableSelf(Location location) : DMASTExpression(location), IDMASTCallable;
 
 public sealed class DMASTScopeIdentifier(

DMCompiler/Compiler/DM/DMParser.cs

@@ -195,6 +195,7 @@ public DMASTFile File() {
                     if (statements.Count == 0) return null;
                 }
             } while (Delimiter());
+
             Whitespace();
 
             return statements;
@@ -673,6 +674,7 @@ public DMASTFile File() {
                         procStatements.Add(statement);
                 }
             } while (Delimiter() || statement is DMASTProcStatementLabel);
+
             Whitespace();
 
             return (procStatements.Count > 0 ? procStatements : null, setStatements.Count > 0 ? setStatements : null);
@@ -1518,6 +1520,7 @@ private DMASTProcStatementSwitch.SwitchCase[] SwitchInner() {
 
                     Delimiter();
                 } while (Check(TokenType.DM_Comma));
+
                 Whitespace();
                 ConsumeRightParenthesis();
                 Whitespace();
@@ -1837,7 +1840,6 @@ private void ExpressionTo(out DMASTExpression endRange, out DMASTExpression? ste
             DMASTExpression? value = ExpressionAssign();
 
             while (value != null && Check(TokenType.DM_In)) {
-
                 Whitespace();
                 DMASTExpression? list = ExpressionAssign();
                 RequireExpression(ref list, "Expected a container to search in");
@@ -2349,6 +2351,7 @@ private bool Newline() {
 
             while (Check(TokenType.Newline)) {
             }
+
             return hasNewline;
         }
 
@@ -2800,7 +2803,6 @@ private void BracketWhitespace() {
                         Compiler.Emit(WarningCode.BadToken, CurrentLoc,
                             $"Only one type path can be used, ignoring {pathType}");
                 }
-
             } while (Check(TokenType.DM_Bar));
 
             if (parenthetical) {

DMCompiler/Compiler/DMPreprocessor/DMPreprocessor.cs

@@ -673,6 +673,7 @@ private void HandlePragmaDirective() {
                     compiler.Emit(WarningCode.BadDirective, warningTypeToken.Location, "Runtime pragmas do not support directive: info");
                     return;
                 }
+
                 compiler.SetPragma(warningCode, ErrorLevel.Notice);
                 break;
             case "warning":
@@ -681,6 +682,7 @@ private void HandlePragmaDirective() {
                     compiler.Emit(WarningCode.BadDirective, warningTypeToken.Location, "Runtime pragmas do not support directive: warn");
                     return;
                 }
+
                 compiler.SetPragma(warningCode, ErrorLevel.Warning);
                 break;
             case "error":

DMCompiler/Compiler/DMPreprocessor/DMPreprocessorLexer.cs

@@ -554,10 +554,10 @@ private bool TryMacroKeyword(string text, [NotNullWhen(true)] out Token? token)
                 token = null; // maybe should use ref instead of out?
                 return false;
         }
+
         return true;
     }
 
-
     ///<summary>
     /// Lex a string <br/>
     ///</summary>

OpenDreamClient/Interface/Controls/ControlGrid.cs

@@ -13,7 +13,6 @@ public ControlGrid(ControlDescriptor controlDescriptor, ControlWindow window) :
 
     protected override Control CreateUIElement() {
         _grid = new GridContainer() {
-
         };
 
         return _grid;

OpenDreamClient/Interface/DMF/IDMFProperty.cs

@@ -522,8 +522,8 @@ public bool Equals(string comparison) {
 }
 
 #region Serializers
-/// TLDR everything is a string passed to the constructor
 
+/// TLDR everything is a string passed to the constructor
 [TypeSerializer]
 public sealed class DMFPropertyStringSerializer : ITypeSerializer<DMFPropertyString, ValueDataNode>, ITypeCopyCreator<DMFPropertyString> {
     public DMFPropertyString Read(ISerializationManager serializationManager, ValueDataNode node,