Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of Important Object IDs in test/validation set #35

Closed
dongyang2011 opened this issue Mar 12, 2024 · 3 comments
Closed

Inclusion of Important Object IDs in test/validation set #35

dongyang2011 opened this issue Mar 12, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@dongyang2011
Copy link

dongyang2011 commented Mar 12, 2024

Hi there, will the test/validation set include important object IDs (the "key_object_infos" dict)? If not, how will questions of subsequent steps (prediction/planning, etc.) be composed with the ID?

@dongyang2011
Copy link
Author

In issue #11 @ChonghaoSima mentioned: "we assume the model already 'know' the key objects". Dose this imply that the model should be capable of identifying key objects even amidst varying c-id or locations from the predictions?

@ChonghaoSima ChonghaoSima self-assigned this Mar 12, 2024
@ChonghaoSima ChonghaoSima added the good first issue Good for newcomers label Mar 12, 2024
@ChonghaoSima
Copy link
Contributor

Thank you for a good question. We put some effort here to bypass the problem of id-issue.

  1. The model still needs to identify the key objects.
  2. If the model identifies the key objects with different id-number in the gt (the c-id in your sentence), we will use the IoU matching of the predicted and the GT 2D coordinate, to find the corrent object in your predicted answer. That being said, the c-id is not a matter here. You could have a look at our evaluation code about this.

@dongyang2011
Copy link
Author

Thanks for the comment!

@ChonghaoSima ChonghaoSima pinned this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants