More portable fixes. #359
Merged
More portable fixes. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nakarlsson @hefloryd This is ready for review and merge. Thanks! |
|
Hi, Consider squashing the commits regards |
seanyen
force-pushed
the
portable_fix
branch
from
b5524b3
to
0c096a9
Compare
* Replaced CMAKE_SOURCE_DIR with CMAKE_CURRENT_LIST_DIR to make SOEM CMakeLists.txt more relocatable. * Installed SOEM CMake config files to a more universal location to search.
seanyen
force-pushed
the
portable_fix
branch
from
0c096a9
to
58028cc
Compare
|
@nakarlsson Thanks for the feedback. I just updated the commit messages. |
hefloryd
approved these changes
Dec 17, 2019
|
@nakarlsson @hefloryd Happy new year! Just wanted to check in and see any additional help I can do to move it forward. |
|
Sorry for the delay, christas holidays you know. |
|
Thanks for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is attempting to make SOEM more portable and resilient to different build environment:
Replace
${CMAKE_SOURCE_DIR}with${CMAKE_CURRENT_LIST_DIR}, so this SOEM project can be relocatable into different folder hierarchy. This is motivated by enabling Windows build of ROS wrapper project ([master] Enable Windows build. orocos/soem#33).Install
CMakeconfig files intoshare/soem/cmakeopposing tolib/cmake, which is a more universal location for thefind_package()to search.(I have submitted a completed contributor license agreement to the email address as specified.)