Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some improvement on FoE (large mailboxes, busy answer, firmware_update) #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

some improvement on FoE (large mailboxes, busy answer, firmware_update) #56

wants to merge 4 commits into from
+174 −28

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2016

No description provided.

@mheden
Copy link
Collaborator

mheden commented Aug 26, 2016

CLA received.

@mheden
Copy link
Collaborator

mheden commented Sep 9, 2016

Sorry for the delay, I'll look over this as soon as my schedule permits.

nakarlsson
nakarlsson reviewed Sep 10, 2016
View reviewed changes
soem/ethercatfoe.c
@@ -57,8 +57,6 @@
#include "ethercatmain.h"
#include "ethercatfoe.h"

#define EC_MAXFOEDATA 512
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep EC_MAXFOEDATA and set it to EC_MAXMBX

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll commit the change in ethercatfoe with my comment, the changes in firmware we'll leave out.

@gralpli
Copy link

gralpli commented May 2, 2020 •
edited
Loading

This pull request solves a problem for me! Why hasn’t this been accepted yet?

firm_update.c from the master branch always failed with status code -3. Wireshark revealed that the FoE response from the slave contained gibberish. (aFOEp->MbxHeader.mbxtype & 0x0f) evaluated to 0x0a.

I will investigate further what the actual problem was and why this pull request solved it.

@gralpli gralpli mentioned this pull request May 4, 2020
Closed
@nakarlsson
Copy link
Contributor

Some minor updates of the PR for FoE, and I think the update of fimrware update should be handled in a seperate PR. Perhaps you can finish the started work?

@jdeitmerg jdeitmerg mentioned this pull request Feb 21, 2021
Closed
This was referenced Jul 9, 2022
Open
Open
@nakarlsson nakarlsson mentioned this pull request Nov 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mheden @gralpli @nakarlsson