Add method comparison plot docs using pair_plot - #223
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
pre-commit.ci autofix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 22 22
Lines 2470 2470
=======================================
Hits 2409 2409
Misses 61 61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
|
View / edit / reply to this conversation on ReviewNB hannahbaumann commented on 2026-06-15T11:16:41Z The three high-level plotting functions above make it easy to compare computaional results with experimental reference data within an
I wonder if the high-level/low-level distinction is necessary here or if it may be confusing to some users, maybe a slight re-wording could help to put the difference of the inputs more into focus (other functions used FEMap directly, here we work with the numpy arrays directly)? jthorton commented on 2026-06-17T10:14:33Z Updated to remove the high/low-level text and concentrate on the API differences. |
|
View / edit / reply to this conversation on ReviewNB hannahbaumann commented on 2026-06-15T11:16:42Z Line #2. femap_to_methods = FEMap() Was this meant to be jthorton commented on 2026-06-16T10:56:27Z Ah yeah thanks, fixed! |
|
View / edit / reply to this conversation on ReviewNB hannahbaumann commented on 2026-06-15T11:16:43Z Line #5. # and add a second copy with ranom noise added to the values to simulate a second method "random" jthorton commented on 2026-06-16T10:55:54Z Fixed |
|
View / edit / reply to this conversation on ReviewNB hannahbaumann commented on 2026-06-15T11:16:44Z "preparation" jthorton commented on 2026-06-16T10:56:00Z Fixed. |
|
Fixed View entire conversation on ReviewNB |
|
Fixed. View entire conversation on ReviewNB |
|
Ah yeah thanks! View entire conversation on ReviewNB |
|
Updated to remove the high/low-level text and concentrate on the API differences. View entire conversation on ReviewNB |
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @jthorton , lgtm!
Description
Provide a brief description of the PR's purpose here.
Fixes #220 by extending the plotting docs to include examples using pair_plot.
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Checklist
newsentry for new features, bug fixes, or other user facing changes.Status
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.