Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
pre-commit.ci autofix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 22 22
Lines 2470 2470
=======================================
Hits 2409 2409
Misses 61 61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
I had a very brief look through and it looks good. I'll let @hannahbaumann do the real review though. |
| @@ -0,0 +1,3614 @@ | |||
| { | |||
There was a problem hiding this comment.
values should be close to zero.
Maybe just "should be zero" since that's what you would expect with perfect sampling (from a theoretical standpoint)?
Note Not all
[nit] Note:
Reply via ReviewNB
There was a problem hiding this comment.
Thanks changed to "should be zero (assuming perfect sampling)."
hannahbaumann
left a comment
hannahbaumann
left a comment
There was a problem hiding this comment.
Thanks @jthorton , lgtm, just left the two small comments!
3 participants
Description
Provide a brief description of the PR's purpose here.
Drafted by me and cleaned with GPT5
Fixes #221
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Checklist
newsentry for new features, bug fixes, or other user facing changes.Status
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.