Small corrections to one of the example guides. - #231
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 97.53% 97.58% +0.04%
==========================================
Files 22 24 +2
Lines 2470 2645 +175
==========================================
+ Hits 2409 2581 +172
- Misses 61 64 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jthorton
reviewed
Jul 14, 2026
| "metadata": {}, | ||
| "source": [ | ||
| "A key property to consider is whether the graph is fully connected, that is, whether all results are reachable from other results. The ``FEMap`` object provides a method to check this and a visualisation method which can be helpful to identify missing connections in the network.\n", | ||
| "A key property to consider is whether the graph is connected, that is, whether all results are reachable from other results. The ``FEMap`` object provides a method to check this and a visualisation method which can be helpful to identify missing connections in the network.\n", |
Contributor
There was a problem hiding this comment.
Thanks thats a good catch, fully connected is wrong! What about changing this to weakly connected as that is what is needed and would align with the API point check_weakly_connected?
jthorton
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.