Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 86.86% 86.87%
=======================================
Files 11 11
Lines 1439 1440 +1
=======================================
+ Hits 1250 1251 +1
Misses 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 86.86% 86.87%
=======================================
Files 11 11
Lines 1439 1440 +1
=======================================
+ Hits 1250 1251 +1
Misses 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
GPU runners aren't working, but I've tested most of the GPU tests locally and they seem to be passing. |
ijpulidos
approved these changes
Oct 17, 2025
ijpulidos
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this. LGTM!
ijpulidos
pushed a commit
that referenced
this pull request
Nov 26, 2025
(cherry picked from commit 73f74e1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting some of the fixes from OpenFreeEnergy/openfe#1566 to make sure HTF tests still pass till we can migrate the tests.