-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search button #39
Conversation
- added search buttton - fixed footer issue - changed UI a little
- Search button added - Footer issues fixed - UI improvised
- Added search button - Fixed footer issue - Header Changed a little
@@ -9,6 +9,7 @@ | |||
<link rel="stylesheet" type="text/css" href="css/font.css"> | |||
<link rel="stylesheet" type="text/css" href="css/fontawesome-all.min.css"> | |||
<link rel="shortcut icon" type="image/png" href="/icon/icon.png"/> | |||
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can link only to local resources as this extension is intended to work offline. We are using fontawesome-all.min.css
, so, you may consider using this as we must consider the size of our extension as well.
The UI looks good. 👍 I have added a comment regarding a small change. Kindly review it and make corresponding changes. |
Yes okay. ^_^
…On 24 Feb 2018 8:02 pm, "Aditya Chatterjee" ***@***.***> wrote:
The UI looks good. 👍
I have added a comment regarding a small change. Kindly review it and make
corresponding changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AblVVuN8ybrLuZ0kHPSCLNDuvdkglnUlks5tYB2AgaJpZM4SMSi7>
.
|
Some things got messed up hence created a separate PR. So I am closing this one. :) |
Fixes issue:
[#31]
Changes: