fix #389

OpenHausIO · Dec 30, 2023 · 28108d5 · 28108d5
1 parent c810790
commit 28108d5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/components/endpoints/class.command.js b/components/endpoints/class.command.js
@@ -188,13 +188,18 @@ module.exports = class Command {
      * @param {Array} [params] Parameter array
      * @param {Function} [cb] Callback
      */
-    trigger(params, cb = () => { }) {
+    trigger(params, cb) {
 
         if (!cb && params instanceof Function) {
             cb = params;
             params = [];
         }
 
+        if (!params && !cb) {
+            params = [];
+            cb = () => { };
+        }
+
         let worker = this.#privates.get("handler");
         let iface = interfaces.get(this.interface);
 

diff --git a/components/scenes/makro-types.js b/components/scenes/makro-types.js
@@ -27,7 +27,14 @@ module.exports = {
                 "component": "endpoints",
                 "item": endpoint,
                 "method": "trigger",
-                "args": [command]
+                "args": [command, () => {
+
+                    //console.log("Command executed adasdasdfasdfasdfasfdadsfasdf", err || success)
+                    // how should this be catched?
+                    // reject the makro execution if one command fails?
+                    // or ignore it simple, and continue?
+
+                }]
             });
 
             resolve(_id);